Skip to content

Support multiple config directories for a client #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2025

Conversation

Daniel-Kolev
Copy link
Contributor

@Daniel-Kolev Daniel-Kolev commented Aug 5, 2025

What I did

Note: Open for a discussion on whether we should even support this feature given it's coming from a single client at the moment.

Handling a request from LM Studio folks (we have them listed as a client) to support multiple mcp.json config paths. They mentioned that users who started using their app long time ago would have their mcp servers config file in ~/.cache/lm-studio/mcp.json rather than in ~/.lmstudio/mcp.json which is the case for newer version users. This PR tries to handle both directories. Following their ordering of directory lookup

Slack thread for more context

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@Daniel-Kolev Daniel-Kolev marked this pull request as ready for review August 7, 2025 13:03
@Daniel-Kolev Daniel-Kolev requested a review from a team as a code owner August 7, 2025 13:03
Copy link
Contributor

@cmrigney cmrigney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Awesome on adding tests! 💪

@Daniel-Kolev Daniel-Kolev merged commit b95e3fd into main Aug 11, 2025
8 checks passed
@Daniel-Kolev Daniel-Kolev deleted the support-multiple-config-directories-for-a-client branch August 11, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants