Improve engine type detection #129
Conversation
In some cases we may end up misidentifying the underlying engine type. Improve the logic for doing that to make it impossible to identify DD on windows or macos as plain moby. Signed-off-by: Piotr Stankiewicz <[email protected]>
| kind = types.ModelRunnerEngineKindMoby | ||
| } | ||
|
|
||
| if modelRunnerHost != "" && kind == types.ModelRunnerEngineKindMoby { |
There was a problem hiding this comment.
This makes MODEL_RUNNER_HOST unusable on macOS and Windows.
There was a problem hiding this comment.
Hmm, I'll have to have another look into this.
How's that possible at the moment? |
Yep. It can happen if you try to interact with DMR while DD is resetting/starting (basically it's a race where during |
In some cases we may end up misidentifying the underlying engine type. Improve the logic for doing that to make it impossible to identify DD on windows or macos as plain moby.