models: return untagged model information on delete #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p1-0tr
approved these changes
Jul 4, 2025
xenoscopic
reviewed
Jul 7, 2025
pkg/inference/models/manager.go
Outdated
Comment on lines
351
to
354
| w.Header().Set("Content-Type", "text/plain") | ||
| if _, err := w.Write([]byte(out)); err != nil { | ||
| http.Error(w, fmt.Sprintf("error writing response: %v", err), http.StatusInternalServerError) | ||
| } |
Contributor
There was a problem hiding this comment.
I missed the review window on docker/model-distribution#104, but would it maybe make more sense to have DeleteModel return some sort of structure (e.g. []string) and then handle the formatting at the API and CLI layers? E.g. the corresponding DELETE /images response uses a JSON structure to format the results: https://docs.docker.com/reference/api/engine/version/v1.51/#tag/Image/operation/ImageDelete
Contributor
Author
There was a problem hiding this comment.
Done in docker/model-distribution#107, thanks!
doringeman
force-pushed
the
rm-untagged-msg
branch
3 times, most recently
from
3a960df to
efa6abe
Compare
doringeman
force-pushed
the
rm-untagged-msg
branch
from
08199e4 to
9474ef7
Compare
Bump model-distribution to docker/model-distribution@a633223 (current latest) to include docker/model-distribution@67a3bf2. Signed-off-by: Dorin Geman <[email protected]>
doringeman
force-pushed
the
rm-untagged-msg
branch
from
9474ef7 to
2bd09df
Compare
xenoscopic
approved these changes
Jul 11, 2025
|
|
||
| w.Header().Set("Content-Type", "application/json") | ||
| if err := json.NewEncoder(w).Encode(resp); err != nil { | ||
| http.Error(w, fmt.Sprintf("error writing response: %v", err), http.StatusInternalServerError) |
Contributor
There was a problem hiding this comment.
I'm not sure this'll do anything at this point if the encode fails mid-encode, but can't hurt I suppose.
Contributor
Author
There was a problem hiding this comment.
I guess it at least overwrites the previously set "Content-Type", "application/json" and send back an error.
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 23, 2025
* Added workflow to package a safetensors model * Build llama-converter image * No need to install git-lfs * Use linux/amd6 platform * No need for intermediate image stage llama-converter * remove duplicated FROM * Update README.md * add prerpare-matrix step as gguf workflow * fix example * llamacpp tag always came from the input * Update README.md
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 24, 2025
* Added workflow to package a safetensors model * Build llama-converter image * No need to install git-lfs * Use linux/amd6 platform * No need for intermediate image stage llama-converter * remove duplicated FROM * Update README.md * add prerpare-matrix step as gguf workflow * fix example * llamacpp tag always came from the input * Update README.md
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Oct 2, 2025
use docker API client interfaces instead of concrete type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return untagged model information on
DELETE <inference-prefix>/models/{name}requests.Bump model-distribution to docker/model-distribution@67a3bf2 (to also include docker/model-distribution@08f8ace) for the change of
m.distributionClient.DeleteModel.This is how the
docker model rmoutput will look like with these changes: