Skip to content

runner: Do not allow CORS headers set by the inference engines #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doringeman merged 1 commit into from
Jul 14, 2025
Merged

runner: Do not allow CORS headers set by the inference engines #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/inference/scheduling/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@ func run(
r.URL.Path = trimRequestPathToOpenAIRoot(r.URL.Path)
r.URL.RawPath = trimRequestPathToOpenAIRoot(r.URL.RawPath)
}
proxy.ModifyResponse = func(resp *http.Response) error {
// CORS headers are set by the CorsMiddleware from pkg/inference/cors.go,
// so we remove them here to avoid duplication and potential misconfiguration.
resp.Header.Del("Access-Control-Allow-Origin")
return nil
}
proxy.Transport = transport
proxyLog := log.Writer()
proxy.ErrorLog = logpkg.New(proxyLog, "", 0)
Expand Down