recorder: fix memory leak due to slice appends #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slicing the first element of a slice doesn't shrink the capacity of the underlying slice, so continual appends will cause the memory to grow unbounded. The proper solution here would be a better data structure, but since we want this JSON-encodable, we can do a memory shuffle for now. Signed-off-by: Jacob Howard <[email protected]>
xenoscopic
force-pushed
the
recorder-memory-leak
branch
from
b43cd64 to
2fd8517
Compare
ilopezluna
approved these changes
Jul 18, 2025
p1-0tr
approved these changes
Jul 18, 2025
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Oct 2, 2025
…el-pull-docs docs: note about quantized models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slicing the first element of a slice doesn't shrink the capacity of the underlying slice, so continual appends will cause the memory to grow unbounded. The proper solution here would be a better data structure, but since we want this JSON-encodable, we can do a memory shuffle for now.
We can also avoid map lookups on every access.