recorder: use model ref rather than model ID #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilopezluna
approved these changes
Jul 18, 2025
Contributor
Author
|
A bit more work seems to be needed here, I think both on our side and the Pinata side; I'll finish it up Monday. |
The model ID is already recorded elsewhere and used as the record key. Signed-off-by: Jacob Howard <[email protected]>
xenoscopic
force-pushed
the
recorder-use-model-ref
branch
from
a5de542 to
3b5b4b5
Compare
doringeman
added a commit
to doringeman/model-runner
that referenced
this pull request
Oct 2, 2025
Use model structs imported from model-runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The model ID is already recorded elsewhere and used as the record key.