fix(scripts): handle unset gpu_device_flag array safely

[doringeman]

This syntax only expands the array if it's set and non-empty, avoiding the "unbound variable" error when the array is empty.

Follow-up to #171 which can make make docker-run fail:

scripts/docker-run.sh: line 15: gpu_device_flag[@]: unbound variable
make: *** [docker-run] Error 1

Summary by Sourcery

Bug Fixes:

• Use parameter expansion "${arr[@]+"${arr[@]}"}" for gpu_device_flag to prevent unbound variable errors in docker-run.sh

[Copilot]

Pull Request Overview

This PR fixes a bash scripting error that occurs when the gpu_device_flag array is empty, preventing the "unbound variable" error in the docker-run script.

• Uses safe array expansion syntax to handle empty arrays without causing script failures
• Ensures the docker run command executes successfully even when no GPU devices are detected

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Introduces a conditional expansion guard for the gpu_device_flag array in docker-run.sh to prevent unbound variable errors when the array is empty.

File-Level Changes

Change	Details	Files
Implement safe expansion of gpu_device_flag array.	Replaced direct expansion "${gpu_device_flag[@]}" with conditional expansion guard. Applied Bash parameter expansion syntax: ${gpu_device_flag[@]+"${gpu_device_flag[@]}"}. Retained all existing arguments ordering within the docker run command.	scripts/docker-run.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the docker-run.sh script where an "unbound variable" error could occur if the gpu_device_flag array was not set or was empty. The change introduces a more robust array expansion syntax, ensuring the script executes reliably without encountering this specific error, thereby improving the stability of the make docker-run command.

Highlights

• Error Handling: Implemented a fix for an "unbound variable" error in scripts/docker-run.sh that occurred when the gpu_device_flag array was empty.
• Script Robustness: Enhanced the docker-run.sh script to safely expand the gpu_device_flag array using "${array[@]+${array[@]}}" syntax, preventing script failures.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider initializing gpu_device_flag as an empty array (e.g., declare -a gpu_device_flag=()) at the top of the script to avoid unbound variable checks.
• For readability, you could wrap the GPU flags in an explicit if-statement checking array length instead of using the parameter expansion hack.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider initializing gpu_device_flag as an empty array (e.g., `declare -a gpu_device_flag=()`) at the top of the script to avoid unbound variable checks.
- For readability, you could wrap the GPU flags in an explicit if-statement checking array length instead of using the parameter expansion hack.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request correctly fixes a potential 'unbound variable' error in the docker-run.sh script that can occur when set -u is enabled and the gpu_device_flag array is empty. The change uses an idiomatic bash parameter expansion to safely handle this case. The fix is effective and targeted. I have one suggestion to improve the maintainability of the code.