Skip to content

Revert "fix(scheduling): query "/" to check if a runner is ready" #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doringeman merged 1 commit into from
Oct 3, 2025
Merged

Revert "fix(scheduling): query "/" to check if a runner is ready" #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/inference/scheduling/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ func (r *runner) wait(ctx context.Context) error {
default:
}
// Create and execute a request targeting a known-valid endpoint.
Copy link

Copilot AI Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting to /v1/models endpoint may reintroduce the original issue that PR #170 was intended to fix. Consider documenting why this revert is necessary and whether the underlying problem has been resolved through other means.

Suggested change
// Create and execute a request targeting a known-valid endpoint.
// Create and execute a request targeting a known-valid endpoint.
// NOTE: This readiness check uses the `/v1/models` endpoint.
// This was reverted to `/v1/models` following PR #170, which originally changed the endpoint
// to address [describe the issue, e.g., a bug, security, or compatibility problem].
// The underlying problem has been [resolved/mitigated] through [other means/changes], so reverting is safe.
// If the issue resurfaces, consider updating this endpoint and reviewing PR #170 for context.

Copilot uses AI. Check for mistakes.
readyRequest, err := http.NewRequestWithContext(ctx, http.MethodGet, "http://localhost/", http.NoBody)
readyRequest, err := http.NewRequestWithContext(ctx, http.MethodGet, "http://localhost/v1/models", http.NoBody)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability and to avoid magic strings, it's a good practice to define this URL as a constant. For example, you could declare const readinessProbeURL = "http://localhost/v1/models" at the package level and use it here.

if err != nil {
return fmt.Errorf("readiness request creation failed: %w", err)
}
Expand Down
Loading