Conversation
Reviewer's GuideIntroduces a Go workspace for multi-module management, upgrades core dependencies, refactors the CLI to use the local model-runner module, and strengthens CI/build configurations to enforce module hygiene and correct test execution. Class diagram for CLI import refactorclassDiagram
class "cmd/cli/commands/package.go" {
+builder (from model-runner/pkg/distribution)
+registry (from model-runner/pkg/distribution)
+tarball (from model-runner/pkg/distribution)
+types (from model-runner/pkg/distribution)
}
class "cmd/cli/desktop/desktop.go" {
+distribution (from model-runner/pkg/distribution/distribution)
+inference (from model-runner/pkg/inference)
+models (from model-runner/pkg/inference/models)
+scheduling (from model-runner/pkg/inference/scheduling)
}
"cmd/cli/commands/package.go" --|> "model-runner/pkg/distribution"
"cmd/cli/desktop/desktop.go" --|> "model-runner/pkg/distribution/distribution"
"cmd/cli/desktop/desktop.go" --|> "model-runner/pkg/inference"
"cmd/cli/desktop/desktop.go" --|> "model-runner/pkg/inference/models"
"cmd/cli/desktop/desktop.go" --|> "model-runner/pkg/inference/scheduling"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds Go workspace configuration to support multi-module development by introducing go.work and go.work.sum files. It restructures the project to use local module dependencies instead of external ones and updates build configuration.
Key changes:
- Introduces Go workspace with
go.workfile containing root module andcmd/climodule - Removes external dependency on
github.com/docker/model-distributionand replaces with local package paths - Updates build configuration to use workspace-relative paths
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.work | New Go workspace file defining workspace modules |
| go.work.sum | Generated workspace checksums for dependencies |
| go.mod | Updated dependency versions and removed unused dependencies |
| cmd/cli/go.mod | Removed external model-distribution dependency, added local replace directive |
| cmd/cli/docker-bake.hcl | Fixed Dockerfile path in build configuration |
| cmd/cli/desktop/desktop.go | Updated import path from external to local package |
| cmd/cli/commands/package.go | Updated import paths from external to local packages |
| cmd/cli/Dockerfile | Fixed make command to run in correct directory |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 11 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
go.workfor model-runner and model-runner/cmd/cli. Ref: https://go.dev/doc/tutorial/workspaces.validate-teststarget.go mod tidyandgo work syncare run.This PR should help with the errors in #194 and also ease the importing (using of)
github.com/docker/model-runneringithub.com/docker/model-runner/cmd/cli(model-cli).Summary by Sourcery
Add go.work workspace and switch CLI to use local module while upgrading dependencies and test tooling
Enhancements:
Chores:
Summary by Sourcery
Add Go workspace support, refactor CLI to use local module, bump dependencies, and enforce module hygiene in CI
Enhancements:
Build:
CI:
Chores: