-
Notifications
You must be signed in to change notification settings - Fork 79
Standardize on one-character prompts everywhere #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rather than a mix of 3 and 1. Signed-off-by: Eric Curtin <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideStandardize on single-character prompts in the interactive CLI by replacing all multi-character '... ' prompts with '. ' in the readMultilineInput and readline configurations. Class diagram for updated prompt configuration in CLI input handlingclassDiagram
class RunCommand {
+readMultilineInput(cmd, scanner)
- prompt changed from "... " to ". "
}
class ReadlinePrompt {
+Prompt: string
+AltPrompt: string
+Placeholder: string
+AltPlaceholder: string
- AltPrompt changed from "... " to ". "
}
RunCommand --> ReadlinePrompt
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the user experience within the command-line interface by standardizing the visual cue for multi-line input. By unifying the prompt character, the change aims to provide a more consistent and streamlined interaction for users entering multi-line commands or messages. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Standardize continuation prompts to a single-character format for consistency across interactive input modes.
- Change multiline continuation prompt from "... " to ". " in readMultilineInput
- Update readline AltPrompt from "... " to ". "
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request standardizes the multiline input prompt to a single-character prompt, which improves UI consistency across the CLI. The changes in cmd/cli/commands/run.go are straightforward and correctly implement this standardization. To further enhance maintainability, I recommend defining the new prompt string as a constant to avoid duplication, as detailed in my specific comment.
Rather than a mix of 3 and 1.
Summary by Sourcery
Standardize CLI continuation prompts to use a single-character "." instead of "..."
Enhancements: