Skip to content

chore: remove unused NewModelWithConfigArchive #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
doringeman merged 1 commit into from
Oct 16, 2025
Merged

chore: remove unused NewModelWithConfigArchive #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions pkg/distribution/internal/safetensors/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,40 +72,6 @@ func NewModel(paths []string) (*Model, error) {
}, nil
}

// NewModelWithConfigArchive creates a new safetensors model with a config archive
func NewModelWithConfigArchive(safetensorsPaths []string, configArchivePath string) (*Model, error) {
model, err := NewModel(safetensorsPaths)
if err != nil {
return nil, err
}

// Add config archive layer
if configArchivePath != "" {
// Check if a config archive layer already exists
for _, layer := range model.layers {
mediaType, err := layer.MediaType()
if err == nil && mediaType == types.MediaTypeVLLMConfigArchive {
return nil, fmt.Errorf("model already has a config archive layer")
}
}

configLayer, err := partial.NewLayer(configArchivePath, types.MediaTypeVLLMConfigArchive)
if err != nil {
return nil, fmt.Errorf("create config archive layer from %q: %w", configArchivePath, err)
}

diffID, err := configLayer.DiffID()
if err != nil {
return nil, fmt.Errorf("get config archive layer diffID: %w", err)
}

model.layers = append(model.layers, configLayer)
model.configFile.RootFS.DiffIDs = append(model.configFile.RootFS.DiffIDs, diffID)
}

return model, nil
}

// discoverSafetensorsShards attempts to auto-discover all shards for a given safetensors file
// It looks for the pattern: <name>-XXXXX-of-YYYYY.safetensors
// Returns (nil, nil) for single-file models, (paths, nil) for complete shard sets,
Expand Down