Skip to content

Conversation

@ericcurtin
Copy link
Contributor

The ones that are too verbose for normal usage.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a --debug flag across various command-line interface commands to provide users with more precise control over the verbosity of debug messages. This change ensures that detailed diagnostic output is only displayed when explicitly requested, leading to a cleaner default user experience while still offering robust troubleshooting capabilities when needed.

Highlights

  • Debug Flag Introduction: A new --debug flag has been introduced for several CLI commands, including install-runner, reinstall-runner, restart-runner, start-runner, and run.
  • Refactored Debug Logging: Debug message verbosity is now controlled by the explicit --debug command-line flag, replacing the previous reliance on the DEBUG environment variable.
  • Function Signature Updates: Key internal functions such as ensureStandaloneRunnerAvailable, runInstallOrStart, CreateControllerContainer, and tryGetBindAscendMounts have been updated to accept and propagate the new debug boolean parameter.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `cmd/cli/commands/run.go:679-680` </location>
<code_context>
 			}

-			if _, err := ensureStandaloneRunnerAvailable(cmd.Context(), asPrinter(cmd)); err != nil {
+			debug, _ := cmd.Flags().GetBool("debug")
+			if _, err := ensureStandaloneRunnerAvailable(cmd.Context(), asPrinter(cmd), debug); err != nil {
 				return fmt.Errorf("unable to initialize standalone model runner: %w", err)
 			}
</code_context>

<issue_to_address>
**issue (bug_risk):** Error from GetBool("debug") is ignored; consider handling it explicitly.

Handling the error from flag parsing will help prevent silent failures and improve reliability.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a --debug flag to several commands to control verbose logging, replacing the previous environment variable-based check. The changes correctly propagate the debug flag through various functions. I've found two issues: one is a bug where the debug flag is not correctly passed during automatic runner installation, and the other is a minor code redundancy in the run command. Overall, this is a good improvement for controlling log verbosity.

@ericcurtin ericcurtin force-pushed the debug-logs branch 2 times, most recently from c06d158 to 7d1deff Compare November 7, 2025 15:07
The ones that are too verbose for normal usage.

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin ericcurtin merged commit f998715 into main Nov 10, 2025
10 checks passed
@ericcurtin ericcurtin deleted the debug-logs branch November 10, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants