De-duplicate code

[ericcurtin]

Common code de-duplicated

[gemini-code-assist]

Summary of Changes

Hello @ericcurtin, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving code maintainability and reducing redundancy by de-duplicating common patterns across the codebase. It introduces shared utility functions for CLI argument parsing and flag definitions, abstracts common model artifact logic into a base structure, and centralizes the execution flow for backend inference runners. These changes lead to a cleaner, more consistent, and easier-to-manage codebase.

Highlights

• CLI Argument Parsing De-duplication: Introduced common utility functions requireExactArgs and requireMinArgs in cmd/cli/commands/utils.go to standardize argument validation across various CLI commands, replacing repetitive custom logic.
• CLI Flag Definition Consolidation: Created addRunnerFlags function and runnerFlagOptions struct in cmd/cli/commands/utils.go to centralize the definition of common flags for runner-related commands, reducing boilerplate.
• Model Artifact Abstraction: Refactored model artifact implementations (GGUF and Safetensors) by introducing a BaseModel struct in pkg/distribution/internal/partial/model.go. This BaseModel now provides common methods for types.ModelArtifact, eliminating duplicated code in specific model format files.
• Backend Runner Execution Standardization: Implemented a new RunBackend utility function in pkg/inference/backends/runner.go to encapsulate common logic for starting, managing, and logging backend processes (like llama.cpp and vLLM). This significantly reduces duplication in backend implementations.
• Error Type Simplification: Removed the ReferenceError struct from pkg/distribution/distribution/errors.go, streamlining error handling in that package.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Consider using cobra’s built-in ExactArgs and MinimumNArgs validators instead of custom requireExactArgs/requireMinArgs functions to reduce duplication.
• The BaseModel struct’s ModelConfigFile field could be renamed to just ConfigFile for brevity and clarity when embedding and marshaling.
• The Logger interface in runner.go duplicates methods from pkg/logging; consider using the existing logging interface to avoid defining an extra interface.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider using cobra’s built-in ExactArgs and MinimumNArgs validators instead of custom requireExactArgs/requireMinArgs functions to reduce duplication.
- The BaseModel struct’s ModelConfigFile field could be renamed to just ConfigFile for brevity and clarity when embedding and marshaling.
- The Logger interface in runner.go duplicates methods from pkg/logging; consider using the existing logging interface to avoid defining an extra interface.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request does a great job of de-duplicating code across several commands and backend implementations. The introduction of helper functions like requireExactArgs, addRunnerFlags, and the backends.RunBackend function, as well as the BaseModel for distribution artifacts, significantly improves code clarity and maintainability.

I've left a couple of comments on minor issues. One is a small inconsistency in a user-facing error message, and the other is a suggestion to handle the llama.cpp binary name more robustly to ensure correctness on Windows, which also helps with further de-duplication.