Revert incomplete resumable downloads implementation#409
Closed
Copilot wants to merge 4 commits intofork-go-containersfrom
Closed
Revert incomplete resumable downloads implementation#409Copilot wants to merge 4 commits intofork-go-containersfrom
Copilot wants to merge 4 commits intofork-go-containersfrom
Conversation
So it a download gets interrupted, we do not have to start again from scratch Signed-off-by: Eric Curtin <eric.curtin@docker.com>
Co-authored-by: ericcurtin <1694275+ericcurtin@users.noreply.github.com>
Co-authored-by: ericcurtin <1694275+ericcurtin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement resumable downloads functionality
Revert incomplete resumable downloads implementation
Nov 14, 2025
33d0436 to
94a100b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resumable downloads implementation introduced test failures and security alerts. The implementation attempted to add resume logic at the store layer without proper integration with the HTTP fetcher layer.
Changes
GetIncompleteSize()method, and hash verification for resumed downloads fromblobs.gofetcher.goandimage.goNewReaderWithOffset()function fromreader.goclient.goWhy the revert
The implementation had architectural issues:
Net result: -242 lines, all tests passing, zero security alerts.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.