Skip to content

Conversation

@doringeman
Copy link
Contributor

Correct bench command usage to show MODEL as required

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an inconsistency in the CLI's bench command, ensuring that both its internal definition and external documentation accurately convey that the MODEL argument is required. This change enhances user clarity and improves the overall accuracy of the command-line interface.

Highlights

  • CLI Command Definition: The bench command's definition in cmd/cli/commands/bench.go has been updated to explicitly mark MODEL as a required argument by removing the surrounding square brackets from its Use field.
  • Documentation Alignment: The usage documentation for the docker model bench command in cmd/cli/docs/reference/docker_model_bench.yaml has been synchronized to reflect that MODEL is a mandatory argument, matching the updated command definition.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `cmd/cli/commands/bench.go:60` </location>
<code_context>

 	cmd := &cobra.Command{
-		Use:   "bench [MODEL]",
+		Use:   "bench MODEL",
 		Short: "Benchmark a model's performance at different concurrency levels",
 		Long: `Benchmark a model's performance showing tokens per second at different concurrency levels.
</code_context>

<issue_to_address>
**suggestion (bug_risk):** Align cobra Args validation with the now-required MODEL argument.

Since the `Use` string now treats `MODEL` as required, the command should enforce this via `Args` (e.g., `Args: cobra.ExactArgs(1)`) so it doesn’t accept runs without a model despite the help text indicating otherwise.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the usage string for the bench command in both the command implementation and its documentation. By changing [MODEL] to MODEL, it accurately reflects that the model argument is required, which aligns with the cobra.ExactArgs(1) validation. The changes are straightforward, correct, and improve the command's usability by providing clear and accurate usage instructions to the user.

@doringeman doringeman merged commit 7b48321 into docker:main Dec 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants