-
Notifications
You must be signed in to change notification settings - Fork 79
fix(cli): correct bench command usage to show MODEL as required #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dorin Geman <[email protected]>
Summary of ChangesHello @doringeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an inconsistency in the CLI's Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `cmd/cli/commands/bench.go:60` </location>
<code_context>
cmd := &cobra.Command{
- Use: "bench [MODEL]",
+ Use: "bench MODEL",
Short: "Benchmark a model's performance at different concurrency levels",
Long: `Benchmark a model's performance showing tokens per second at different concurrency levels.
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Align cobra Args validation with the now-required MODEL argument.
Since the `Use` string now treats `MODEL` as required, the command should enforce this via `Args` (e.g., `Args: cobra.ExactArgs(1)`) so it doesn’t accept runs without a model despite the help text indicating otherwise.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the usage string for the bench command in both the command implementation and its documentation. By changing [MODEL] to MODEL, it accurately reflects that the model argument is required, which aligns with the cobra.ExactArgs(1) validation. The changes are straightforward, correct, and improve the command's usability by providing clear and accurate usage instructions to the user.
Correct
benchcommand usage to showMODELas required