fix(cli): correct ls command usage and apply model filter when listing in OpenAI format

[doringeman]

Correct ls command usage to show MODEL as optional.
Apply model filter when listing in OpenAI format.

E.g.,

$ docker model ls smollm2 --openai
{
    "object": "list",
    "data": [
        {
            "id": "ai/smollm2:latest",
            "object": "model",
            "created": 1742816981,
            "owned_by": "docker"
        }
    ]
}

[gemini-code-assist]

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the docker model ls command by correcting its usage description to mark the MODEL argument as optional. Crucially, it also implements the necessary logic to ensure that model filtering is correctly applied when the command is used with the --openai flag, providing a more consistent and robust user experience for listing models.

Highlights

• CLI Command Usage: The docker model ls command's usage string has been updated to correctly indicate that the MODEL argument is optional.
• OpenAI Format Filtering: Model filtering is now properly applied when listing models using the --openai flag, ensuring consistent filtering behavior across output formats.
• Refactored Model Filtering Logic: New helper functions normalizeModelFilter and matchesModelFilter were introduced to centralize and simplify the logic for filtering models, improving code readability and maintainability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly updates the ls command to accept an optional MODEL argument for filtering and implements this filtering for the --openai format. The refactoring of filtering logic into helper functions is a good improvement for code clarity and reuse. I have one suggestion to optimize the filtering of the OpenAI model list for better memory efficiency.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Now that the usage string advertises an optional [MODEL] argument, consider adding explicit cobra.Args validation (e.g., cobra.MaximumNArgs(1)) so that unexpected extra arguments are rejected consistently rather than silently ignored.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Now that the usage string advertises an optional [MODEL] argument, consider adding explicit cobra.Args validation (e.g., cobra.MaximumNArgs(1)) so that unexpected extra arguments are rejected consistently rather than silently ignored.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}