chore: remove unused memory estimation code and gpuinfo package

[doringeman]

Cleanup after #504 which made this code unused. Remove GetRequiredMemoryForModel from Backend interface and all implementations, along with supporting functions in llamacpp and the entire gpuinfo package.

[gemini-code-assist]

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant code cleanup by eliminating unused memory estimation logic and the associated gpuinfo package. This change is a direct follow-up to a previous refactoring (#504) that rendered these components obsolete. The primary goal is to remove dead code, simplifying the codebase and reducing maintenance overhead, without impacting current functionality.

Highlights

• Code Removal: The entire pkg/gpuinfo package, responsible for GPU VRAM size estimation across different operating systems, has been completely removed.
• Interface Update: The GetRequiredMemoryForModel method has been removed from the Backend interface in pkg/inference/backend.go.
• Backend Implementations Cleanup: All implementations of GetRequiredMemoryForModel have been removed from the llamacpp, mlx, and vllm backends, along with supporting functions and unused imports in llamacpp.
• Test Code Alignment: The mockBackend in pkg/inference/scheduling/loader_test.go has been updated to reflect the removal of the GetRequiredMemoryForModel method.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• Now that GetRequiredMemoryForModel and the GGUF parsing helpers are removed, check whether types like inference.RequiredMemory and inference.ErrGGUFParse (and any related error paths) are still referenced elsewhere; if not, they should be deleted to avoid leaving dead code.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Now that `GetRequiredMemoryForModel` and the GGUF parsing helpers are removed, check whether types like `inference.RequiredMemory` and `inference.ErrGGUFParse` (and any related error paths) are still referenced elsewhere; if not, they should be deleted to avoid leaving dead code.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request effectively removes all unused memory estimation code and the gpuinfo package, aligning with the stated objective of cleaning up after a previous change (#504). The GetRequiredMemoryForModel method has been successfully removed from the Backend interface and all its implementations across llamacpp, mlx, and vllm backends. The entire gpuinfo package, along with its platform-specific implementations, has also been removed. The changes are consistent and well-executed, contributing to a cleaner and more maintainable codebase.

[ilopezluna]

oh there was much more! thanks :D