Skip to content

Conversation

@doringeman
Copy link
Contributor

Tiny cleanup after #477.
CC @denyszhak

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a cleanup operation on the Makefile by removing all references and build configurations for the SGLang CPU variant. The existing docker-build-sglang target is now repurposed to build the CUDA-enabled SGLang image, simplifying the build process and ensuring consistency with recent changes. This change contributes to a more streamlined and maintainable build system.

Highlights

  • SGLang CPU Variant Removal: The Makefile no longer includes targets or configurations for building or running an SGLang CPU variant Docker image.
  • SGLang Build Target Consolidation: The docker-build-sglang target has been updated to exclusively build the CUDA-enabled SGLang Docker image, eliminating the need for a separate docker-build-sglang-cuda target.
  • Makefile Cleanup: Obsolete variables, phony targets, build rules, and help messages related to the SGLang CPU and explicit CUDA variants have been removed, streamlining the Makefile.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Now that docker-build-sglang is always built with LLAMA_SERVER_VARIANT=cuda and VLLM_BASE_IMAGE, consider renaming the image/tag (e.g., latest-sglang-cuda) or adding a brief comment to avoid confusion for users expecting a CPU variant based on the tag name.
  • Since the CPU path for SGLang is removed, double-check whether the BASE_IMAGE variable is still needed in the Makefile or can be simplified/cleaned up further where it was previously used for SGLang.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Now that `docker-build-sglang` is always built with `LLAMA_SERVER_VARIANT=cuda` and `VLLM_BASE_IMAGE`, consider renaming the image/tag (e.g., `latest-sglang-cuda`) or adding a brief comment to avoid confusion for users expecting a CPU variant based on the tag name.
- Since the CPU path for SGLang is removed, double-check whether the `BASE_IMAGE` variable is still needed in the Makefile or can be simplified/cleaned up further where it was previously used for SGLang.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully removes the SGLang CPU variant from the Makefile, streamlining the build and run targets. This aligns with the stated goal of cleaning up after the referenced PR. The changes correctly remove the DOCKER_IMAGE_SGLANG_CUDA variable, the corresponding .PHONY declarations, and the build/run targets for the CUDA variant, while updating the docker-build-sglang target to build the CUDA version. The help messages have also been updated to reflect these changes.

@ericcurtin ericcurtin merged commit ca12aae into docker:main Dec 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants