-
Notifications
You must be signed in to change notification settings - Fork 79
chore(makefile): remove sglang CPU variant #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dorin Geman <[email protected]>
Summary of ChangesHello @doringeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a cleanup operation on the Makefile by removing all references and build configurations for the SGLang CPU variant. The existing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Now that
docker-build-sglangis always built withLLAMA_SERVER_VARIANT=cudaandVLLM_BASE_IMAGE, consider renaming the image/tag (e.g.,latest-sglang-cuda) or adding a brief comment to avoid confusion for users expecting a CPU variant based on the tag name. - Since the CPU path for SGLang is removed, double-check whether the
BASE_IMAGEvariable is still needed in the Makefile or can be simplified/cleaned up further where it was previously used for SGLang.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Now that `docker-build-sglang` is always built with `LLAMA_SERVER_VARIANT=cuda` and `VLLM_BASE_IMAGE`, consider renaming the image/tag (e.g., `latest-sglang-cuda`) or adding a brief comment to avoid confusion for users expecting a CPU variant based on the tag name.
- Since the CPU path for SGLang is removed, double-check whether the `BASE_IMAGE` variable is still needed in the Makefile or can be simplified/cleaned up further where it was previously used for SGLang.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request successfully removes the SGLang CPU variant from the Makefile, streamlining the build and run targets. This aligns with the stated goal of cleaning up after the referenced PR. The changes correctly remove the DOCKER_IMAGE_SGLANG_CUDA variable, the corresponding .PHONY declarations, and the build/run targets for the CUDA variant, while updating the docker-build-sglang target to build the CUDA version. The help messages have also been updated to reflect these changes.
Tiny cleanup after #477.
CC @denyszhak