Allow specifying a target llama-server version #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doringeman
approved these changes
Jun 10, 2025
Contributor
doringeman
left a comment
doringeman
left a comment
There was a problem hiding this comment.
Sure! This allows testing new versions before tagging them as latest without any code change!
xenoscopic
approved these changes
Jun 10, 2025
Contributor
xenoscopic
left a comment
xenoscopic
left a comment
There was a problem hiding this comment.
This seems super useful to me.
main.go
Outdated
| llamacpp.ShouldUpdateServerLock.Unlock() | ||
| } | ||
|
|
||
| desiredSeverVersion, ok := os.LookupEnv("SERVER_VERSION") |
Contributor
There was a problem hiding this comment.
Only minor nit is that maybe we should prefix the environment variable with an engine spec, e.g. LLAMACPP_SERVER_VERSION, for the future where we have multiple backends.
Signed-off-by: Piotr Stankiewicz <[email protected]>
p1-0tr
force-pushed
the
ps-llama-server-version-lock
branch
from
00f4925 to
f17e7a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found being able to lock the
llama-serverversion to be useful at times. If we want to merge this it may make sense to come up with a cleaner solution. LMK what you think.