Rebuild ModelsManager and Scheduler routers with new CORS origins #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p1-0tr
reviewed
Jun 10, 2025
| return m | ||
| } | ||
|
|
||
| func (m *Manager) RebuildRoutes(allowedOrigins []string) { |
There was a problem hiding this comment.
Feels like something that should happen behind a lock, or is the consumer of this API supposed to lock?
Contributor
Author
There was a problem hiding this comment.
You're right, added a lock in 784d6df (compare the force push changes).
doringeman
force-pushed
the
rebuild-routes-cors
branch
from
7eeb62e to
784d6df
Compare
p1-0tr
reviewed
Jun 10, 2025
pkg/inference/models/manager.go
Outdated
| maximumConcurrentModelPulls = 2 | ||
| ) | ||
|
|
||
| var lock sync.Mutex |
Signed-off-by: Dorin Geman <[email protected]>
doringeman
force-pushed
the
rebuild-routes-cors
branch
from
784d6df to
60166a9
Compare
p1-0tr
approved these changes
Jun 10, 2025
ericcurtin
referenced
this pull request
in ericcurtin/model-runner
Sep 21, 2025
* Enable SmolLM 3 template. - Add `replace` method for string type and update unit tests. - Support slice expression with omitted start or end index and update unit tests. - Fix the bug that `in` operator does not work for string type. - Update testing script to support fetching `chat-template.jinja` when the template is not in `tokenizer_config.json`. Test passed with SmolLM 3B model: https://huggingface.co/HuggingFaceTB/SmolLM3-3B * Update test cases of string replace. --------- Co-authored-by: Olivier Chafik <[email protected]>
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 23, 2025
* Provides API for packaging models - introduces builder package for building artifacts - extracts registry packge for direct interaction with OCI registries Signed-off-by: Emily Casey <[email protected]> * cleanup Signed-off-by: Emily Casey <[email protected]> * slim down artifact interface Signed-off-by: Emily Casey <[email protected]> * cleanup Signed-off-by: Emily Casey <[email protected]> --------- Signed-off-by: Emily Casey <[email protected]>
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 23, 2025
* Provides API for packaging models - introduces builder package for building artifacts - extracts registry packge for direct interaction with OCI registries Signed-off-by: Emily Casey <[email protected]> * cleanup Signed-off-by: Emily Casey <[email protected]> * slim down artifact interface Signed-off-by: Emily Casey <[email protected]> * cleanup Signed-off-by: Emily Casey <[email protected]> --------- Signed-off-by: Emily Casey <[email protected]>
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 24, 2025
* Provides API for packaging models - introduces builder package for building artifacts - extracts registry packge for direct interaction with OCI registries Signed-off-by: Emily Casey <[email protected]> * cleanup Signed-off-by: Emily Casey <[email protected]> * slim down artifact interface Signed-off-by: Emily Casey <[email protected]> * cleanup Signed-off-by: Emily Casey <[email protected]> --------- Signed-off-by: Emily Casey <[email protected]>
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Sep 24, 2025
* Provides API for packaging models - introduces builder package for building artifacts - extracts registry packge for direct interaction with OCI registries Signed-off-by: Emily Casey <[email protected]> * cleanup Signed-off-by: Emily Casey <[email protected]> * slim down artifact interface Signed-off-by: Emily Casey <[email protected]> * cleanup Signed-off-by: Emily Casey <[email protected]> --------- Signed-off-by: Emily Casey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rebuilding the routers with new allowed origins for CORS.