loader: trigger idle runner eviction immediately if a runner is defunct #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dorin Geman <[email protected]>
Merged
xenoscopic
approved these changes
Jun 12, 2025
Contributor
xenoscopic
left a comment
xenoscopic
left a comment
There was a problem hiding this comment.
Great idea, sorry for my initial confusion. My brain is running on the 1B parameter model at the moment 🫠
ericcurtin
referenced
this pull request
in ericcurtin/model-runner
Sep 21, 2025
* Port content handling of google/minja#72 to python test logic * Pin dependency versions * add clangd/ to .gitignore * disable QwQ-32B test
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Oct 2, 2025
add compose metadata subcommand to return information about model runner cli usage as a Compose provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify
idleCheckDurationso that when it's called randomly, it also verifies whether there's a defunct runner, and if so, returns0to trigger an immediate check.