bump model-distribution #81
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xenoscopic
approved these changes
Jun 13, 2025
ekcasey
reviewed
Jun 16, 2025
| } | ||
|
|
||
| w := httptest.NewRecorder() | ||
| w := newMutexResponseRecorder() |
Contributor
There was a problem hiding this comment.
I don't think we can assume the real http.ResponseWriter is thread safe and we might be papering over real issues with this change to use a thread-safe version in the tests. It looks to me like the concurrent writes are happening within the pull implementation.
My best guess is this is that this is appearing now b/c with the per-layer progress reporting we are no longer waiting for the progress writing from one layer to complete before we start writing progress for the next layer.
Contributor
Author
|
Closing because the race is in the pull implementation: docker/model-distribution#89 |
ericcurtin
pushed a commit
to ericcurtin/model-runner
that referenced
this pull request
Sep 21, 2025
doringeman
pushed a commit
to doringeman/model-runner
that referenced
this pull request
Oct 2, 2025
* Inspect remote model * Do not include tags in remote model, as it will be nil * Update docs * Update message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.