display QEMU version installed on the runner #116
Draft
+113
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
qemu-version
branch
7 times, most recently
from
833fb17 to
b62a62e
Compare
Signed-off-by: CrazyMax <[email protected]>
Signed-off-by: CrazyMax <[email protected]>
crazy-max
force-pushed
the
qemu-version
branch
from
b62a62e to
b79376c
Compare
tonistiigi
reviewed
Jan 6, 2024
There was a problem hiding this comment.
I'm not sure I understand how this works and CI runs don't seem to report much. It is assuming it can access qemu binary but I don't think this is the case most of the time.
This would be valuable if it could report the installed version but I'm not sure how it is possible to do that without adding some special test binaries to tonistiigi/binfmt image. I guess what would help would be just to report if setup-qemu-action set up some emulators or was the setup skipped because emulator was already found on the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.