Skip to content

Add validation message for missing workflow catalog file #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kathy-t merged 1 commit into from
May 8, 2025
Merged

Add validation message for missing workflow catalog file #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
*.class
.idea
target

# Mobile Tools for Java (J2ME)
.mtj.tmp/
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/io/dockstore/language/SnakemakeWorkflowPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public class SnakemakeWorkflowPlugin extends Plugin {
public static final Logger LOG = LoggerFactory.getLogger(SnakemakeWorkflowPlugin.class);
public static final String SNAKEMAKE_WORKFLOW_CATALOG_YML = "/.snakemake-workflow-catalog.yml";
public static final String INVALID_INITIAL_PATH_MESSAGE = "the primary descriptor path must be the Snakefile";
public static final String MISSING_WORKFLOW_CATALOG_MESSAGE = "the Snakemake workflow catalog file is missing";


/**
Expand Down Expand Up @@ -68,7 +69,7 @@ public VersionTypeValidation validateWorkflowSet(String initialPath, String cont
if (!initialPathPattern().matcher(initialPath).matches()) {
return new VersionTypeValidation(false, Map.of(initialPath, INVALID_INITIAL_PATH_MESSAGE));
}
VersionTypeValidation validation = new VersionTypeValidation(indexedFiles.containsKey(SNAKEMAKE_WORKFLOW_CATALOG_YML), new HashMap<>());
VersionTypeValidation validation = new VersionTypeValidation(indexedFiles.containsKey(SNAKEMAKE_WORKFLOW_CATALOG_YML), Map.of(SNAKEMAKE_WORKFLOW_CATALOG_YML, MISSING_WORKFLOW_CATALOG_MESSAGE));
// TODO hook up some real validation
return validation;
}
Expand Down