-
Notifications
You must be signed in to change notification settings - Fork 101
feat: add code chunking functionality #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bridgetmcg
wants to merge
16
commits into
docling-project:main
Choose a base branch
from
bridgetmcg:feat/code-chunking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10,985
−217
Open
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
63c7739
initial code chunking for docling-core
bridgetmcg 23be660
DCO Remediation Commit for Bridget McGinn <[email protected]>
bridgetmcg 431d357
include language detections, add code chunking into hierarchical chunker
bridgetmcg f3175c2
add serializer, internal marking of chunkers, typing
bridgetmcg f41474d
Update pyproject.toml
bridgetmcg 850c5cc
Update docling_core/transforms/chunker/hierarchical_chunker.py
bridgetmcg 1a01de8
run all pre-commit less pytest
bridgetmcg 025aea3
update test files for code ID
bridgetmcg 14db10e
DCO Remediation Commit for Bridget McGinn <[email protected]>
bridgetmcg c801a2f
update uv.lock
bridgetmcg c2ba93c
revert to stricter treesitter versioning due to compatibility
bridgetmcg b9dec1b
DCO Remediation Commit for Bridget McGinn <[email protected]>
bridgetmcg 455654d
remove language detection (to be run by client, i.e. docling)
vagenas 8a2e61f
align new dependency specs
vagenas 11340ab
address backticks, ABC, and supported languages feedback
bridgetmcg fc64987
remove Language class and reuse CodeLanguageLabel
bridgetmcg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -266,14 +266,22 @@ def __str__(self): | |
| return str(self.value) | ||
|
|
||
| def to_language(self): | ||
| """Convert CodeLanguageLabel to CodeLanguage enum.""" | ||
| """Convert CodeLanguageLabel to Language enum for code chunking.""" | ||
| from docling_core.transforms.chunker.code_chunk_utils.utils import Language | ||
|
|
||
| mapping = { | ||
| CodeLanguageLabel.PYTHON: Language.PYTHON, | ||
| CodeLanguageLabel.JAVA: Language.JAVA, | ||
| CodeLanguageLabel.C: Language.C, | ||
| CodeLanguageLabel.TYPESCRIPT: Language.TYPESCRIPT, | ||
| CodeLanguageLabel.JAVASCRIPT: Language.JAVASCRIPT, | ||
| return Language.from_code_language_label(self) | ||
|
|
||
| @classmethod | ||
| def get_supported_languages(cls): | ||
| """Get the set of CodeLanguageLabels that are supported for code chunking.""" | ||
| return { | ||
| cls.PYTHON, | ||
| cls.JAVA, | ||
| cls.C, | ||
| cls.TYPESCRIPT, | ||
| cls.JAVASCRIPT, | ||
| } | ||
| return mapping.get(self, None) | ||
|
|
||
| def is_supported_for_chunking(self) -> bool: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this not used currently? |
||
| """Check if this language is supported for code chunking.""" | ||
| return self in self.get_supported_languages() | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.