fix: prevent crash from invalid bbox coordinates in HTML export#142
Merged
fix: prevent crash from invalid bbox coordinates in HTML export#142
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Contributor
|
❌ DCO Check Failed Hi @samiuc, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for samiullahchattha <Sami.Ullah1@ibm.com>
I, samiullahchattha <Sami.Ullah1@ibm.com>, hereby add my Signed-off-by to this commit: 4d1cf05d9a3f1f74618cc16692c4170dad5c905e"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
cau-git
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when
doc.export_to_html()is called on a document with invalid geometry (e.g., a bounding box wherey_max<y_min), Pillow's underlyingcropfunction raises aValueError. This causes the entire visualization process to crash, preventing the generation of reports if even one document has bad data.The PR logs the error with the specific page number and continues processing the remaining pages and documents. It inserts a clear error message directly into the generated HTML for the page that failed to render.