Closed
Conversation
Signed-off-by: Magnus Samuelsen <97634880+MagnusS0@users.noreply.github.com>
Also improves documentation Signed-off-by: Magnus Samuelsen <97634880+MagnusS0@users.noreply.github.com>
Contributor
|
✅ DCO Check Passed Thanks @MagnusS0, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Member
|
Thanks @MagnusS0. If you don't mind I can pick it up from here. What we would like to change is:
I expect quick iterations in the next days. |
Contributor
Author
|
Hey @dolfim-ibm absolutely! Excited to test it out when it's ready! |
Merged
Member
|
Superseded by #54. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should build the foundation for new chunking endpoints in docling-project/docling-serve#299.
@dolfim-ibm when you have time please let me know if it was something in this direction you guys were thinking 😊
This pull request introduces a new document chunking feature. The changes include new configuration options for chunking, a chunking implementation using
HybridChunkerfromdocling-core, updates to result handling to support chunked responses, and dependency management for chunking functionality.Document Chunking Feature:
ChunkingOptions,ChunkedDocumentResponseItem, andChunkedDocumentResponsemodels to describe chunking configuration and output format indocling_jobkit/datamodel/chunking.py.DocumentChunkerclass indocling_jobkit/convert/chunking.pyto handle document chunking, caching of chunker instances, and conversion of documents and conversion results into chunked responses.Integration with Conversion Workflow:
ConvertDocumentsOptionsindocling_jobkit/datamodel/convert.pyto includedo_chunkingandchunking_optionsfields, defaults to false for backward compatibility.docling_jobkit/convert/results.pyto support chunked document export when requested,Result Type and Dependency Updates:
ResultTypeunion indocling_jobkit/datamodel/result.pyto includeChunkedDocumentResponse, ensuring chunked results are handled consistently.chunkingdependency group inpyproject.tomlto requiredocling[chunking]for chunking support.Issue resolved by this Pull Request:
Resolves docling-project/docling-serve#44