feat: add support for Path & DocumentStream #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
ehcalabres
force-pushed
the
feat/add-document-stream-and-path-support
branch
from
151ac47 to
dec49f0
Compare
Signed-off-by: GitHub <[email protected]>
ehcalabres
force-pushed
the
feat/add-document-stream-and-path-support
branch
from
dec49f0 to
754eddb
Compare
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
While using
DocumentLoaderwith LangChain, I noticed that althoughpathlib.Pathanddocling.datamodel.base_models.DocumentStreamare supported input types in Docling, the loader here only accepted a string (representing either a file path or URL). This limitation made the integration less flexible and somewhat inconvenient.Changes
This PR adds support for both
DocumentStreamandpathlib.Pathas input types, allowingdocling-langchainto align more closely with the Docling API for document loading.Breaking Changes
To reflect this input change, the
file_pathparameter has been renamed tosource, consistent with the naming used in the Docling converter interface.