Skip to content

Conversation

@kush-gupt
Copy link
Contributor

A seperate PR on top of #33 that aims to add test coverage to the CLI.

The test file was created with assistance from Jules (Google Gemini 2.5 pro agent)

* starting to fix cli for multiple providers

Signed-off-by: Kush Gupta <[email protected]>

* ensure file processing happens before temp is removed

Signed-off-by: Kush Gupta <[email protected]>

* remove verbose comments

Signed-off-by: Kush Gupta <[email protected]>

---------

Signed-off-by: Kush Gupta <[email protected]>
Signed-off-by: Kush Gupta <[email protected]>
Signed-off-by: Kush Gupta <[email protected]>
Signed-off-by: Kush Gupta <[email protected]>
Signed-off-by: Kush Gupta <[email protected]>
@mergify
Copy link

mergify bot commented Jun 13, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@ceberam
Copy link
Collaborator

ceberam commented Jul 16, 2025

Thanks @kush-gupt for your contribution.
Regarding the AI-generated code in the test file, while we do not generally prohibit AI-generated code, we would require to:

  • Ensure that the terms and conditions of the generative AI tool (in this case, Jules) (a) allow its AI Code to be used for external Open Source development and (b) are consistent with submitting the AI Code under the Docling community contribution guidelines, including enabling it to be used by the project under its Open Source license (MIT license)
  • As a best practice, since you have have substantially altered the file using an AI tool, we recommend adding a comment in the file header (“// this file has been modified with the assistance of AI Tool [X v.Y]”).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants