Skip to content

feat: add rocm image build support and fix cuda#291

Closed
rmdg88 wants to merge 12 commits intodocling-project:mainfrom
rmdg88:rui/ROCm
Closed

feat: add rocm image build support and fix cuda#291
rmdg88 wants to merge 12 commits intodocling-project:mainfrom
rmdg88:rui/ROCm

Conversation

@rmdg88
Copy link
Contributor

@rmdg88 rmdg88 commented Jul 30, 2025

replaced by #292

rmdg88 and others added 10 commits July 24, 2025 17:00
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: Rui Dias Gomes <66125272+rmdg88@users.noreply.github.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2025

DCO Check Passed

Thanks @rmdg88, all your commits are properly signed off. 🎉

@mergify
Copy link

mergify bot commented Jul 30, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

I, rmdg88 <rmdg88@gmail.com>, hereby add my Signed-off-by to this commit: 6b0b56c

Signed-off-by: rmdg88 <rmdg88@gmail.com>
@rmdg88 rmdg88 changed the title Rui/ro cm feat: add rocm image build support Jul 30, 2025
Containerfile Outdated
ARG UV_SYNC_EXTRA_ARGS

RUN --mount=from=ghcr.io/astral-sh/uv:0.7.19,source=/uv,target=/bin/uv \
ARG UV_VERSION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still needed?

@rmdg88 rmdg88 changed the title feat: add rocm image build support feat: add rocm image build support and fix cuda Jul 30, 2025
Signed-off-by: rmdg88 <rmdg88@gmail.com>
@rmdg88 rmdg88 closed this Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants