fix: configuration and performance fixes via upgrade of packages#328
Merged
fix: configuration and performance fixes via upgrade of packages#328
Conversation
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Contributor
|
✅ DCO Check Passed Thanks @dolfim-ibm, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
vku-ibm
approved these changes
Aug 20, 2025
|
Documentation updates How did I do? Any feedback? |
pvliesdonk
added a commit
to pvliesdonk/docling-serve
that referenced
this pull request
Feb 28, 2026
…erManagerConfig The `allow_custom_vlm_config`, `allow_custom_picture_description_config`, and `allow_custom_code_formula_config` flags exist in docling-jobkit's `DoclingConverterManagerConfig` but were never exposed in docling-serve. As a result, `vlm_pipeline_custom_config` (and its siblings) always raised a 422 error regardless of any env var an administrator set. Add the three fields to `DoclingServeSettings`, wired via pydantic-settings to: - `DOCLING_SERVE_ALLOW_CUSTOM_VLM_CONFIG` - `DOCLING_SERVE_ALLOW_CUSTOM_PICTURE_DESCRIPTION_CONFIG` - `DOCLING_SERVE_ALLOW_CUSTOM_CODE_FORMULA_CONFIG` Pass the fields through in both `DoclingConverterManagerConfig` instantiation sites (`orchestrator_factory.py` and `__main__.py`), following the same pattern established for `allow_external_plugins` in docling-project#328. Update `docs/configuration.md` to document the three new env vars. Resolves docling-project#526 Signed-off-by: Peter van Liesdonk <peter@liesdonk.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Docling updates:
Relevant Docling Jobkit updates:
Issue resolved by this Pull Request:
Resolves #325