-
Notifications
You must be signed in to change notification settings - Fork 248
feat: make RQ results_ttl configurable #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make RQ results_ttl configurable #460
Conversation
- Add eng_rq_results_ttl setting to DoclingServeSettings with default 4 hours - Pass results_ttl when creating RQOrchestratorConfig in orchestrator_factory.py - Pass results_ttl when creating RQOrchestratorConfig in rq_worker command - Update configuration documentation with new DOCLING_SERVE_ENG_RQ_RESULTS_TTL setting This allows users to configure the Time To Live for RQ job results in Redis, enabling flexibility for different use cases (long-running workflows, memory optimization, compliance requirements).
|
❌ DCO Check Failed Hi @fclabs, your pull request has failed the Developer Certificate of Origin (DCO) check. This repository supports remediation commits, so you can fix this without rewriting history — but you must follow the required message format. 🛠 Quick Fix: Add a remediation commitRun this command: git commit --allow-empty -s -m "DCO Remediation Commit for Federico Castañeda <[email protected]>
I, Federico Castañeda <[email protected]>, hereby add my Signed-off-by to this commit: 9421bb13ec66983f76f4bc1bdaba52d1d27fef39"
git push🔧 Advanced: Sign off each commit directlyFor the latest commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/main
git push --force-with-leaseMore info: DCO check report |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: Federico Castañeda <[email protected]>
Signed-off-by: Federico Castañeda <[email protected]>
dolfim-ibm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi, @dolfim-ibm What else it is required to merge this one? Thank you in advance. |
Issue resolved by this Pull Request:
Resolves #458
Description
This PR makes the RQ
results_ttl(Time To Live) configurable via theDOCLING_SERVE_ENG_RQ_RESULTS_TTLenvironment variable, addressing the feature request in issue #458.Changes
eng_rq_results_ttlsetting toDoclingServeSettingswith default value of 4 hours (matching current behavior)orchestrator_factory.pyto passresults_ttlwhen creatingRQOrchestratorConfig__main__.pyto passresults_ttlwhen creatingRQOrchestratorConfigin therq_workercommanddocs/configuration.mdto document the new settingBenefits
Usage
Users can now configure the TTL via environment variable:
Or in
.envfile:Testing