-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix:Remove unused StoppingCriteria import and comment default-groups in pyproject.toml #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
@lifejwang11 I don't think these changes are needed. Please motivate your proposal. |
|
@dolfim-ibm I use uv sync |
This is because you are using an old version of |
|
✅ DCO Check Passed Thanks @lifejwang11, all your commits are properly signed off. 🎉 |
|
@dolfim-ibm thanks,Is there anything wrong with this useless import? |
|
@lifejwang11 removing the unused import looks fine. We only need you to make the CI checks and DCO pass (see advice from the DCO bot). |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…yproject.toml Signed-off-by: lifejwang11 <[email protected]>
Signed-off-by: lifejwang11 <[email protected]>
|
@cau-git thanks |


Remove unused StoppingCriteria import and comment default-groups in pyproject.toml
Checklist: