Skip to content

Conversation

@lifejwang11
Copy link

Remove unused StoppingCriteria import and comment default-groups in pyproject.toml

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

@dosubot
Copy link

dosubot bot commented Oct 29, 2025

Related Documentation

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

@mergify
Copy link

mergify bot commented Oct 29, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@lifejwang11 lifejwang11 changed the title Remove unused StoppingCriteria import and comment default-groups in pyproject.toml fix:Remove unused StoppingCriteria import and comment default-groups in pyproject.toml Oct 29, 2025
@dolfim-ibm
Copy link
Contributor

@lifejwang11 I don't think these changes are needed. Please motivate your proposal.

@lifejwang11
Copy link
Author

@dolfim-ibm I use uv sync
image
next change is unuse import

@dolfim-ibm
Copy link
Contributor

@dolfim-ibm I use uv sync image next change is unuse import

This is because you are using an old version of uv. Please upgrade to 0.7+ and it should work out of the box.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

DCO Check Passed

Thanks @lifejwang11, all your commits are properly signed off. 🎉

@lifejwang11
Copy link
Author

@dolfim-ibm thanks,Is there anything wrong with this useless import?

@cau-git
Copy link
Contributor

cau-git commented Nov 4, 2025

@lifejwang11 removing the unused import looks fine. We only need you to make the CI checks and DCO pass (see advice from the DCO bot).

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@lifejwang11
Copy link
Author

@cau-git thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants