fix: convert PIL images to RGB before picture description#3014
Open
aatrey56 wants to merge 2 commits intodocling-project:mainfrom
Open
fix: convert PIL images to RGB before picture description#3014aatrey56 wants to merge 2 commits intodocling-project:mainfrom
aatrey56 wants to merge 2 commits intodocling-project:mainfrom
Conversation
Non-RGB image modes (RGBA, L, P) cause failures or incorrect output when passed to transformers processors or VLM engines, which expect 3-channel RGB input. Convert in the base model's __call__ so all subclasses (transformers, engine, API) benefit from a single fix. Closes docling-project#3000 Signed-off-by: aatrey56 <aatrey.sahay@gmail.com>
…rsion fix: convert PIL images to RGB before picture description
Contributor
|
✅ DCO Check Passed Thanks @aatrey56, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
Related Documentation Checked 15 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents frequently contain images in non-RGB modes — PNGs with transparency (RGBA), grayscale scans (L), or palette/indexed color (P). These were being passed directly to
_annotate_imageswithout any mode check. Transformers processors and VLM engines require 3-channel RGB input, so any non-RGB image would either crash the pipeline or produce incorrect output silently.The fix is a single '.convert("RGB")' call in 'PictureDescriptionBaseModel.call', at the point where images are batched before being forwarded to '_annotate_images'. Placing it in the base class means all three subclasses benefit automatically:
'PictureDescriptionVlmModel' (transformers), 'PictureDescriptionVlmEngineModel' (engine abstraction), and 'PictureDescriptionApiModel'.
'Image.convert("RGB")' is safe to call unconditionally — if the image is already RGB it returns a copy unchanged.
Issue resolved by this Pull Request:
Resolves #3000
Checklist