fix: normalize hyphens and spaces in layout label mapping for Egret models#3118
Closed
majiayu000 wants to merge 1 commit intodocling-project:mainfrom
Closed
fix: normalize hyphens and spaces in layout label mapping for Egret models#3118majiayu000 wants to merge 1 commit intodocling-project:mainfrom
majiayu000 wants to merge 1 commit intodocling-project:mainfrom
Conversation
…odels Fixes docling-project#3053 Signed-off-by: majiayu000 <1835304752@qq.com>
Contributor
|
✅ DCO Check Passed Thanks @majiayu000, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
@majiayu000 thanks for the PR, but we will fix this at the source by updating the EGRET family models on hugging-face with the proper id2label config. Please see also #3053 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3053
All Egret layout models (
DOCLING_LAYOUT_EGRET_MEDIUM/LARGE/XLARGE) fail on init because_build_label_map()only calls.upper()on HuggingFace label names. Egret configs use hyphenated labels (e.g.List-item,Page-footer,Document Index) which don't match theDocItemLabelenum that uses underscores (LIST_ITEM,PAGE_FOOTER,DOCUMENT_INDEX).Changes
.replace("-", "_").replace(" ", "_")after.upper()in_build_label_map()to normalize all separator stylestests/test_layout_label_map.pywith tests for hyphenated, space-separated, underscore, and invalid labelsTest plan
pre-commit run --all-filespasses (Ruff + MyPy)List-item,Page-footer,Document Index, etc.) map correctly toDocItemLabelenums