fix: catch PermissionError on Windows when input is a directory#3151
Closed
zlplzp123wyt wants to merge 4 commits intodocling-project:mainfrom
Closed
fix: catch PermissionError on Windows when input is a directory#3151zlplzp123wyt wants to merge 4 commits intodocling-project:mainfrom
zlplzp123wyt wants to merge 4 commits intodocling-project:mainfrom
Conversation
On Windows, pathlib.Path.read_bytes() called on a directory raises PermissionError (Errno 13) instead of IsADirectoryError (Errno 21) which is raised on Linux/macOS. This caused the CLI to crash when passing a directory as source on Windows. Fixes docling-project#3138
Contributor
|
✅ DCO Check Passed Thanks @zlplzp123wyt, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: zlplzp123wyt <zlplzp123wyt@users.noreply.github.com>
…ithub.com> I, zlplzp123wyt <zlplzp123wyt@users.noreply.github.com>, hereby add my Signed-off-by to this commit to resolve the DCO check failure on PR docling-project#3151. Signed-off-by: zlplzp123wyt <zlplzp123wyt@users.noreply.github.com>
…ithub.com> I, zlplzp123wyt <zlplzp123wyt@users.noreply.github.com>, hereby add my Signed-off-by to this commit: 717dcdf Signed-off-by: zlplzp123wyt <zlplzp123wyt@users.noreply.github.com>
Member
|
Duplicate of #3140 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3138
Problem
On Windows,
pathlib.Path.read_bytes()called on a directory raisesPermissionError(Errno 13) instead ofIsADirectoryError(Errno 21) which is raised on Linux/macOS.The CLI handler at
docling/cli/main.py:657only catchesIsADirectoryError, so thePermissionErrorpropagates as an unhandled exception when passing a directory assourceon Windows.Fix
Changed
except IsADirectoryError:toexcept (IsADirectoryError, PermissionError):to handle both exceptions across platforms.This is a minimal, safe fix — the handler logic remains unchanged, we just accept both exception types that indicate "this is a directory".