Skip to content

crash fix when using a custom dmp_path regex #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

crash fix when using a custom dmp_path regex #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0193ad1
crash fix when using a custom dmp_path regex
Nov 12, 2019
8a33eb3
Do a log.exception when there's a crash on your dmp_path configuration
Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions django_mako_plus/router/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def resolve(self, path):
match.kwargs.pop('dmp_app', None) or self.dmp.options['DEFAULT_APP'],
match.kwargs.pop('dmp_page', None) or self.dmp.options['DEFAULT_PAGE'],
match.kwargs.pop('dmp_function', None) or 'process_request',
match.kwargs.pop('dmp_urlparams', '').strip(),
(match.kwargs.pop('dmp_urlparams', None) or '').strip(),
)
if VERSION < (2, 2):
return ResolverMatch(
Expand All @@ -218,7 +218,7 @@ def resolve(self, path):
# this is a hack, but the resolver error page doesn't give other options.
# the sad face is to catch the dev's attention in Django's printout
msg = "◉︵◉ Pattern matched, but discovery failed: {}".format(vdne)
log.debug("%s %s", match.url_name, msg)
log.exception("%s %s", match.url_name, msg)
raise Resolver404({
# this is a bit convoluted, but it makes the PatternStub work with Django 1.x and 2.x
'tried': [[ PatternStub(match.url_name, msg, PatternStub(match.url_name, msg, None)) ]],
Expand Down