Update logic for overriding :algorithm in add_index #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails (at least version 7.1) raises an error if the `:algorithm` option is set to :default, before this code gets invoked. Instead of allowing a custom `:default` option, we can instead just check whether the options[:algorithm] key is present. This is what the `remove_index` method below does, and allows us to use `algorithm: nil` to disable the `:concurrently` option.
jordan-brough
force-pushed
the
fix-remove-index
branch
from
e43f478 to
2e63d11
Compare
|
@CharlesDelannoy any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address #154
Rails (at least version 7.1) raises an error if the
:algorithmoption is set to:default, before this code gets invoked.Instead of allowing a custom
:defaultoption, we can instead just check whether theoptions[:algorithm]key is present. This is what the existingremove_indexmethod does already:safe-pg-migrations/lib/safe-pg-migrations/plugins/statement_insurer.rb
Lines 67 to 68 in b0efa6d
and this will allow us to use
algorithm: nilto disable the:concurrentlyoption.Note: I haven't tested this change directly, but I added a monkey-patch to my own app that does essentially the same thing.