-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow UUIDs for Blameable fields #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
franmomu
merged 6 commits into
doctrine-extensions:main
from
fwolfsjaeger:feature/blameable-allow-uuid
Jun 8, 2024
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
002c169
Added UUID in allowed types list for Blameable fields in Annotation, …
fwolfsjaeger 862ac8d
Added CHANGELOG.md entry
fwolfsjaeger 21fff3f
Added Blameable UUID test
fwolfsjaeger bb28d1c
Moved CHANGELOG.md entry to [Unreleased]
fwolfsjaeger 4a35964
Also allow ULIDs
fwolfsjaeger 44c2806
Update composer.json
fwolfsjaeger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,6 +37,8 @@ class Yaml extends File implements Driver | |
'one', | ||
'string', | ||
'int', | ||
'ulid', | ||
'uuid', | ||
]; | ||
|
||
/** | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the Doctrine Behavioral Extensions package. | ||
* (c) Gediminas Morkevicius <[email protected]> http://www.gediminasm.org | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Gedmo\Tests\Blameable; | ||
|
||
use Doctrine\Common\EventManager; | ||
use Gedmo\Blameable\Blameable; | ||
use Gedmo\Blameable\BlameableListener; | ||
use Gedmo\Tests\Blameable\Fixture\Entity\Company; | ||
use Gedmo\Tests\Tool\BaseTestCaseORM; | ||
use Symfony\Component\Uid\Uuid; | ||
use Symfony\Component\Uid\UuidV6; | ||
|
||
final class BlameableUuidTest extends BaseTestCaseORM | ||
{ | ||
private const COMPANY = Company::class; | ||
|
||
private UuidV6 $uuid; | ||
|
||
protected function setUp(): void | ||
{ | ||
parent::setUp(); | ||
|
||
$this->uuid = Uuid::v6(); | ||
|
||
$listener = new BlameableListener(); | ||
$listener->setUserValue($this->uuid); | ||
|
||
$evm = new EventManager(); | ||
$evm->addEventSubscriber($listener); | ||
|
||
$this->getDefaultMockSqliteEntityManager($evm); | ||
} | ||
|
||
public function testBlameableUuid(): void | ||
{ | ||
$company = new Company(); | ||
$company->setName('ACME'); | ||
|
||
self::assertInstanceOf(Blameable::class, $company); | ||
|
||
$this->em->persist($company); | ||
$this->em->flush(); | ||
$this->em->clear(); | ||
|
||
/** | ||
* @var Company $foundCompany | ||
*/ | ||
$foundCompany = $this->em->getRepository(self::COMPANY)->findOneBy(['name' => 'ACME']); | ||
$created = $foundCompany->getCreated(); | ||
$createdUuid = $created instanceof Uuid ? $created->toRfc4122() : null; | ||
|
||
self::assertSame($this->uuid->toRfc4122(), $createdUuid); | ||
} | ||
|
||
protected function getUsedEntityFixtures(): array | ||
{ | ||
return [ | ||
self::COMPANY, | ||
]; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the Doctrine Behavioral Extensions package. | ||
* (c) Gediminas Morkevicius <[email protected]> http://www.gediminasm.org | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Gedmo\Tests\Blameable\Fixture\Entity; | ||
|
||
use Doctrine\DBAL\Types\Types; | ||
use Doctrine\ORM\Mapping as ORM; | ||
use Gedmo\Blameable\Blameable; | ||
use Gedmo\Mapping\Annotation as Gedmo; | ||
use Symfony\Component\Uid\Uuid; | ||
use Symfony\Component\Uid\UuidV6; | ||
|
||
/** | ||
* @ORM\Entity | ||
*/ | ||
#[ORM\Entity] | ||
class Company implements Blameable | ||
{ | ||
/** | ||
* @var int|null | ||
* | ||
* @ORM\Id | ||
* @ORM\GeneratedValue | ||
* @ORM\Column(type="integer") | ||
*/ | ||
#[ORM\Id] | ||
#[ORM\GeneratedValue] | ||
#[ORM\Column(type: Types::INTEGER)] | ||
private $id; | ||
|
||
/** | ||
* @var string|null | ||
* | ||
* @ORM\Column(name="name", type="string", length=128) | ||
*/ | ||
#[ORM\Column(name: 'name', type: Types::STRING, length: 128)] | ||
private $name; | ||
|
||
/** | ||
* @var UuidV6|null | ||
* | ||
* @Gedmo\Blameable(on="create") | ||
* @ORM\Column(name="created", type="uuid") | ||
*/ | ||
#[ORM\Column(name: 'created', type: 'uuid')] | ||
#[Gedmo\Blameable(on: 'create')] | ||
private $created; | ||
|
||
public function getId(): ?int | ||
{ | ||
return $this->id; | ||
} | ||
|
||
public function setName(?string $name): void | ||
{ | ||
$this->name = $name; | ||
} | ||
|
||
public function getName(): ?string | ||
{ | ||
return $this->name; | ||
} | ||
|
||
public function getCreated(): ?Uuid | ||
{ | ||
return $this->created; | ||
} | ||
|
||
public function setCreated(?UuidV6 $created): void | ||
{ | ||
$this->created = $created; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.