Added the "forceUseAttributeReader" option, which allows you to use AttributeReader automatically#2845
Open
eisberg wants to merge 2 commits intodoctrine-extensions:mainfrom
Open
Conversation
eisberg
force-pushed
the
feature/use-attribute-mapping
branch
from
6dbf528 to
85f9fb0
Compare
eisberg
force-pushed
the
feature/use-attribute-mapping
branch
from
85f9fb0 to
9213dce
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
eisberg
force-pushed
the
feature/use-attribute-mapping
branch
from
426f3ae to
f439e38
Compare
Author
|
Tests added -- The change is important for our large project, where there are about 1000 entities, and mapping is configured in XML files. Gedmo mapping had to be included in the php-classes attributes, since the doctrine with verification enabled prohibits orm.xml add additional settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2613 and #2318
Added "forceUseAttributeReader" option to force use of the attribute reader for Gedmo attributes. Even if the project for Entity is in different NS, the XML driver is used.
By setting this option, Gedmo will only use the attribute reader to retrieve Gedmo meta information with entity settings. This does not affect the operation of Doctrine in any way.
The revision allows you to remove the Gedmo mapping from XML files in projects that use an ORM description in XML format.
Because Doctrine now prohibits placing third-party descriptions in XML files that do not comply with the doctrine schema.
The change with this modification is separated from the other MR, where 2 solutions were proposed.
Some projects (Symfony) will also require changes similar to those in the StofDoctrineExtensionsBundle (PR: stof/StofDoctrineExtensionsBundle#458 )