[WIP] Bump the requirements to PHP 8.1 #2935
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbabker
force-pushed
the
php-81
branch
3 times, most recently
from
d7efb79 to
58661be
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2935 +/- ##
==========================================
- Coverage 78.55% 78.36% -0.20%
==========================================
Files 169 168 -1
Lines 8823 8711 -112
==========================================
- Hits 6931 6826 -105
+ Misses 1892 1885 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbabker
commented
Mar 19, 2025
composer.json
Outdated
| "behat/transliterator": "^1.3", | ||
| "doctrine/collections": "^1.6.5 || ^2.0", |
There was a problem hiding this comment.
Just for reference, all the changes to the minimum versions are either to get to a functional set of dependencies on PHP 8.1 (the transliterator package has errors on older versions, doctrine/common doesn't support some PHP 8.1 reflection changes until 3.1) or change to match the versions currently being installed on the prefer-lowest build. Considering how old some of these releases are it shouldn't be a big deal, I hope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Packagist stats there was a large fall off PHP 7 users after the 3.14 release, which is when the requirement was bumped up to PHP 7.4. Since then, PHP 7.4 and 8.0 combined have had pretty small numbers on newer release branches and is generally now under 5% of the install base. So this PR bumps the requirement to PHP 8.1.
The overwhelming majority of the code changes are from adjusting the Rector and PHP-CS-Fixer configs to apply PHP 8.1 rulesets, with a second pass specifically on the tests to add type declarations there, then only minor corrections or tweaks by my own review along the way.