Skip to content

Test whether soft-deleteable filter is honoured and entities are preserved #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Test whether soft-deleteable filter is honoured and entities are preserved #2939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions tests/Gedmo/SoftDeleteable/SoftDeleteableEntityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,52 @@ public function testSoftDeletedObjectIsRemovedPostFlush(): void
static::assertNull($commentRepo->find($comment->getId()));
}

public function testSoftDeletedObjectNotRemovedPostFlush(): void
{
$this->em->getFilters()->disable(self::SOFT_DELETEABLE_FILTER_NAME);

$repo = $this->em->getRepository(Article::class);
$commentRepo = $this->em->getRepository(Comment::class);

$comment = new Comment();
$commentValue = 'Comment 1';
$comment->setComment($commentValue);

$art0 = new Article();
$field = 'title';
$value = 'Title 1';
$art0->setTitle($value);
$art0->addComment($comment);

$this->em->persist($art0);
$this->em->flush();

$art = $repo->findOneBy([$field => $value]);

static::assertNull($art->getDeletedAt());
static::assertNull($comment->getDeletedAt());
static::assertCount(1, $art->getComments());

$this->em->remove($comment);

// The Comment has been marked for removal, but not yet flushed. This means the
// Comment should still be available.
$sameComment = $commentRepo->find($comment->getId());
static::assertInstanceOf(Comment::class, $sameComment);
static::assertSame($comment, $sameComment);

$this->em->flush();

// Now that we've flushed, but the soft-deleteable filter is
// deactivated. Hence the comment should still be available and find()
// should return the same instance.
$sameComment = $commentRepo->find($comment->getId());
static::assertInstanceOf(Comment::class, $sameComment);
static::assertSame($comment, $sameComment);

$this->em->getFilters()->enable(self::SOFT_DELETEABLE_FILTER_NAME);
}

public function testPostSoftDeleteEventIsDispatched(): void
{
$this->em->getEventManager()->addEventSubscriber(new WithPreAndPostSoftDeleteEventArgsTypeListener());
Expand Down