-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[#2006] Allow integer
type for blamable fields
#2949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sgehrig
wants to merge
4
commits into
doctrine-extensions:main
Choose a base branch
from
sgehrig:bug/#2006-blamable-integer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/* | ||
* This file is part of the Doctrine Behavioral Extensions package. | ||
* (c) Gediminas Morkevicius <[email protected]> http://www.gediminasm.org | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Gedmo\Blameable; | ||
|
||
use Doctrine\Common\EventManager; | ||
use Gedmo\Tests\Blameable\Fixture\Entity\CompanyInteger; | ||
use Gedmo\Tests\Tool\BaseTestCaseORM; | ||
|
||
final class BlameableIntegerTest extends BaseTestCaseORM | ||
{ | ||
private int $userId; | ||
|
||
protected function setUp(): void | ||
{ | ||
parent::setUp(); | ||
|
||
$this->userId = 42; | ||
|
||
$listener = new BlameableListener(); | ||
$listener->setUserValue($this->userId); | ||
|
||
$evm = new EventManager(); | ||
$evm->addEventSubscriber($listener); | ||
|
||
$this->getDefaultMockSqliteEntityManager($evm); | ||
} | ||
|
||
public function testBlameableInteger(): void | ||
{ | ||
$company = new CompanyInteger(); | ||
$company->setName('My Name'); | ||
|
||
$this->em->persist($company); | ||
$this->em->flush(); | ||
$this->em->clear(); | ||
|
||
/** | ||
* @var CompanyInteger $foundCompany | ||
*/ | ||
$foundCompany = $this->em->getRepository(CompanyInteger::class)->findOneBy(['name' => 'My Name']); | ||
$creator = $foundCompany->getCreator(); | ||
sgehrig marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
||
static::assertSame($this->userId, $creator); | ||
} | ||
|
||
protected function getUsedEntityFixtures(): array | ||
{ | ||
return [ | ||
CompanyInteger::class, | ||
]; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
<?php | ||
|
||
namespace Gedmo\Tests\Blameable\Fixture\Entity; | ||
|
||
use Doctrine\DBAL\Types\Types; | ||
use Doctrine\ORM\Mapping as ORM; | ||
use Gedmo\Mapping\Annotation as Gedmo; | ||
|
||
/** | ||
* @ORM\Entity | ||
*/ | ||
#[ORM\Entity] | ||
class CompanyInteger | ||
{ | ||
/** | ||
* @var int|null | ||
* | ||
* @ORM\Id | ||
* @ORM\GeneratedValue | ||
* @ORM\Column(type="integer") | ||
*/ | ||
#[ORM\Id] | ||
#[ORM\GeneratedValue] | ||
#[ORM\Column(type: Types::INTEGER)] | ||
private $id; | ||
|
||
/** | ||
* @ORM\Column(name="name", type="string", length=128) | ||
*/ | ||
#[ORM\Column(name: 'name', type: Types::STRING, length: 128)] | ||
private ?string $name = null; | ||
|
||
/** | ||
* @var int|null | ||
* | ||
* @Gedmo\Blameable(on="create") | ||
* @ORM\Column(name="creator", type="integer") | ||
*/ | ||
#[ORM\Column(name: 'creator', type: Types::INTEGER)] | ||
#[Gedmo\Blameable(on: 'create')] | ||
private $creator; | ||
|
||
public function getId(): ?int | ||
{ | ||
return $this->id; | ||
} | ||
|
||
public function setName(?string $name): void | ||
{ | ||
$this->name = $name; | ||
} | ||
|
||
public function getName(): ?string | ||
{ | ||
return $this->name; | ||
} | ||
|
||
public function getCreator(): ?int | ||
{ | ||
return $this->creator; | ||
} | ||
|
||
public function setCreator(?int $creator): void | ||
{ | ||
$this->creator = $creator; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.