Replace ClassMetadata::getReflectionProperty with (get|set)FieldValue

[Jean85]

This avoids a new deprecation.

Fixes #3032

[mbabker]

The test failures around this line mean if you're going to use a static helper (which really needs to be flagged @internal), it needs to support the persistence ClassMetadata interface and not a single implementation of it. There are a lot of code paths which are supporting MongoDB ODM and ORM (this one included, see the Gedmo\Tests\Mapping\ExtensionODMTest::testGeneratedValues failure on PHP 8.5) so a bulk search/replace isn't feasible.

[Jean85]

Roger. I'm pushing an alternative approach, it should be enough because it relies on direct method existence checks; unfortunately the involved methods are not present in the interface.

[Jean85]

@mbabker I've changed my approach as suggested, but I've discovered some additional stuff:

• all code paths that I changed are in tests -- should I move the helper to the test folder?
• I opened this PR because I thought I needed to solve some deprecations being triggered on my project, while all is already solved in 3ba0096, I just need to update... I can still complete this PR if you want

[mbabker]

• I opened this PR because I thought I needed to solve some deprecations being triggered on my project, while all is already solved in 3ba0096, I just need to update... I can still complete this PR if you want

At this point I'd just change it similar to that commit/PR. After doctrine/persistence#451 getFieldValue() and setFieldValue() are part of the metadata interface and not just something provided by every implementation, so there's no need for consumers to know if they need a reflection property or a property accessor (that's all handled by the metadata).

[Jean85]

@mbabker I did it; the two failing tests are unrelated, I see them failing on main too, locally at least.

[Jean85]

@mbabker now the build is green; I had to fix it with f0960ac, let me know if that's ok.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.82%. Comparing base (eef8a13) to head (f0960ac).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3033      +/-   ##
==========================================
+ Coverage   78.75%   78.82%   +0.06%     
==========================================
  Files         169      169              
  Lines        8695     8688       -7     
==========================================
  Hits         6848     6848              
+ Misses       1847     1840       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.