feat: improve GitHub workflows specs#2158
Closed
shakaran wants to merge 1 commit intodoctrine:4.0.xfrom
Closed
Conversation
Member
|
This looks like AI slop. We don't really need these changes. |
Contributor
Author
I just use Copilot for generate easy the description of the PR. The concurrency, timeouts, permissions and other changes I think that are pretty useful, but as you consider if you want partial o fully this changes I can modify it |
Member
|
Let's do without for now. We may reconsider at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to GitHub Actions Workflows
This PR introduces enhancements to all workflows in
.github/workflowsto boost efficiency, security, and robustness, following GitHub Actions best practices.Changes Made
1. Concurrency
concurrencywithgroup: ${{ github.workflow }}-${{ github.ref }}andcancel-in-progress: truein workflows triggered by PR/push.2. Permissions
contents: read,checks: write,pull-requests: write) in each workflow.3. Timeouts
timeout-minutesto long-running jobs (10 min for PHPUnit, 5 min for upload coverage).4. Additional Triggers
workflow_dispatchincomposer-lint.ymlandrelease-on-milestone-closed.yml.5. Other Optimizations
continuous-integration.yml, addedfail_ci_if_error: falseto the Codecov action.Affected Workflows
coding-standards.ymlcomposer-lint.ymlcontinuous-integration.ymldocumentation.ymlrelease-on-milestone-closed.ymlstatic-analysis.ymltest-dev-stability.ymlwebsite-schema.ymlImpact
These changes follow recommended best practices for GitHub Actions and require no updates to external dependencies.