Merged
Conversation
Using with() on a stub is deprecated. We don't want to check that we call this object with 'doctrine', we just want to only return $mockDoctrine when it is called with 'doctrine' and nothing else.
Not having a version constraint for this package causes deprecations because it expects the framework bundle to define its extension by extending a non deprecated class, and that is not the case with v7 of that bundle.
greg0ire
requested review from
GromNaN,
SenseException,
derrabus,
dmaicher and
ostrolucky
ostrolucky
reviewed
Feb 11, 2026
SenseException
approved these changes
Feb 11, 2026
Member
Author
|
Argh, I should have targeted 2.18 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.