Skip to content

Add proper target names to autowiring aliases#2203

Merged
ostrolucky merged 1 commit intodoctrine:3.3.xfrom
nicolas-grekas:autow-fix
Mar 3, 2026
Merged

Add proper target names to autowiring aliases#2203
ostrolucky merged 1 commit intodoctrine:3.3.xfrom
nicolas-grekas:autow-fix

Conversation

@nicolas-grekas
Copy link
Copy Markdown
Member

#[Target('')] should not need using fixed suffixes. This does it.

This also fixes a few services names that use FQCN ids, which is discouraged practice for bundles (it pollutes the list of autowireable services)

@nicolas-grekas
Copy link
Copy Markdown
Member Author

(failures unrelated)

@ostrolucky
Copy link
Copy Markdown
Member

Let's separate the changes needed to fix target names from changes to service IDs. Fix we can merge quickly, but changes in service IDs are potentially BC breaking and I would like input from others if they agree with those.

@nicolas-grekas
Copy link
Copy Markdown
Member Author

Let's separate the changes

Agreed, split in #2207

@ostrolucky ostrolucky added this to the 3.3.0 milestone Mar 3, 2026
@ostrolucky ostrolucky merged commit 44d66f0 into doctrine:3.3.x Mar 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants