Add proper target names to autowiring aliases#2203
Merged
ostrolucky merged 1 commit intodoctrine:3.3.xfrom Mar 3, 2026
Merged
Conversation
Member
Author
|
(failures unrelated) |
Member
|
Let's separate the changes needed to fix target names from changes to service IDs. Fix we can merge quickly, but changes in service IDs are potentially BC breaking and I would like input from others if they agree with those. |
stof
reviewed
Mar 2, 2026
e15c47c to
a577362
Compare
Member
Author
Agreed, split in #2207 |
ostrolucky
approved these changes
Mar 3, 2026
greg0ire
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#[Target('')]should not need using fixed suffixes. This does it.This also fixes a few services names that use FQCN ids, which is discouraged practice for bundles (it pollutes the list of autowireable services)