Wire the clock argument of PostgreSqlNotifyOnIdleListener#2204
Merged
greg0ire merged 1 commit intodoctrine:3.3.xfrom Mar 4, 2026
Merged
Wire the clock argument of PostgreSqlNotifyOnIdleListener#2204greg0ire merged 1 commit intodoctrine:3.3.xfrom
greg0ire merged 1 commit intodoctrine:3.3.xfrom
Conversation
ostrolucky
reviewed
Mar 2, 2026
nicolas-grekas
force-pushed
the
clock-msg
branch
from
4e8a743 to
71c8516
Compare
ostrolucky
approved these changes
Mar 3, 2026
Member
|
The failures look related |
nicolas-grekas
force-pushed
the
clock-msg
branch
from
71c8516 to
298a8cc
Compare
Member
Author
|
Failure is OK. |
Member
Author
|
I made the clock argument nullable in symfony/symfony#63566 |
symfony-splitter
pushed a commit
to symfony/messenger
that referenced
this pull request
Mar 4, 2026
…leListener (nicolas-grekas) This PR was merged into the 8.1 branch. Discussion ---------- [Messenger] Make $clock nullable in PostgreSqlNotifyOnIdleListener | Q | A | ------------- | --- | Branch? | 8.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT This makes conditional wiring easier, as spotted in doctrine/DoctrineBundle#2204 Commits ------- 52e6cd3f1de [Messenger] Make $clock nullable in PostgreSqlNotifyOnIdleListener
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Mar 4, 2026
…leListener (nicolas-grekas) This PR was merged into the 8.1 branch. Discussion ---------- [Messenger] Make $clock nullable in PostgreSqlNotifyOnIdleListener | Q | A | ------------- | --- | Branch? | 8.1 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT This makes conditional wiring easier, as spotted in doctrine/DoctrineBundle#2204 Commits ------- 52e6cd3 [Messenger] Make $clock nullable in PostgreSqlNotifyOnIdleListener
greg0ire
approved these changes
Mar 4, 2026
Member
|
Thanks @nicolas-grekas ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added in symfony/symfony#63402