Add server_version, autocommit and SSL documentation#2210
Closed
lacatoire wants to merge 1 commit intodoctrine:3.2.xfrom
Closed
Add server_version, autocommit and SSL documentation#2210lacatoire wants to merge 1 commit intodoctrine:3.2.xfrom
lacatoire wants to merge 1 commit intodoctrine:3.2.xfrom
Conversation
Ports useful documentation sections from symfony/symfony-docs that were missing in DoctrineBundle's own configuration reference.
Member
|
I don't think doctrine-bundle should become a place where we combine ORM and DBAL docs. I also don't think this is a place to explain how YAML parses numbers. We could make an exception for some very commonly needed things, but I don't think any of these qualify. For example, most people don't specify server_version, but configure connection via DATABASE_URL. And that one is sufficiently documented through generated .env via symfony flex. Any other opinions? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port useful documentation sections from symfony/symfony-docs that were missing in DoctrineBundle's own configuration reference.
Relates to #1605