Merge pull request #615 from greg0ire/drop-stuff

Drop support for old packages

Author: greg0ire

.github/workflows/continuous-integration.yml

@@ -14,7 +14,7 @@ jobs:
     name: "PHPUnit"
     uses: "doctrine/.github/.github/workflows/[email protected]"
     with:
-      php-versions: '["8.1", "8.2", "8.3", "8.4"]'
+      php-versions: '["8.4"]'
     secrets:
       CODECOV_TOKEN: "${{ secrets.CODECOV_TOKEN }}"
 

UPGRADE.md

@@ -2,6 +2,12 @@
 
 ## 4.0.0
 
+## Dependencies
+
+- Support for PHP < 8.4 has been dropped.
+- Support for `doctrine/orm` < 3 has been dropped.
+- Support for `doctrine/doctrine-bundle` < 3 has been dropped.
+
 ## BC break: final, internal classes
 
 Some classes have been marked as `final` and `@internal` because they are not

composer.json

@@ -24,17 +24,16 @@
     ],
     "homepage": "https://www.doctrine-project.org",
     "require": {
-        "php": "^8.1",
-        "doctrine/doctrine-bundle": "^2.8",
+        "php": "^8.4",
+        "doctrine/doctrine-bundle": "^3",
         "doctrine/migrations": "^3.2",
         "symfony/deprecation-contracts": "^2.1 || ^3",
         "symfony/framework-bundle": "^6.4 || ^7.0"
     },
     "require-dev": {
         "composer/semver": "^3.0",
         "doctrine/coding-standard": "^12",
-        "doctrine/orm": "^2.15 || ^3",
-        "doctrine/persistence": "^3.1",
+        "doctrine/orm": "^3",
         "phpstan/phpstan": "^2",
         "phpstan/phpstan-deprecation-rules": "^2",
         "phpstan/phpstan-phpunit": "^2",

src/EventListener/SchemaFilterListener.php

@@ -5,6 +5,7 @@
 namespace Doctrine\Bundle\MigrationsBundle\EventListener;
 
 use Doctrine\DBAL\Schema\AbstractAsset;
+use Doctrine\DBAL\Schema\Name\OptionallyQualifiedName;
 use Doctrine\ORM\Tools\Console\Command\SchemaTool\UpdateCommand;
 use Doctrine\ORM\Tools\Console\Command\ValidateSchemaCommand;
 use Symfony\Component\Console\Event\ConsoleCommandEvent;
@@ -24,6 +25,7 @@ public function __construct(private string $configurationTableName)
 
     private bool $enabled = false;
 
+    /** @param AbstractAsset<OptionallyQualifiedName>|string $asset */
     public function __invoke(AbstractAsset|string $asset): bool
     {
         if (! $this->enabled) {

tests/DependencyInjection/DoctrineMigrationsExtensionTest.php

@@ -4,7 +4,6 @@
 
 namespace Doctrine\Bundle\MigrationsBundle\Tests\DependencyInjection;
 
-use Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\CacheCompatibilityPass;
 use Doctrine\Bundle\DoctrineBundle\DependencyInjection\DoctrineExtension;
 use Doctrine\Bundle\DoctrineBundle\Registry;
 use Doctrine\Bundle\MigrationsBundle\DependencyInjection\DoctrineMigrationsExtension;
@@ -251,7 +250,7 @@ public function testPrefersEntityManagerOverConnection(): void
             ],
             null,
             [
-                'enable_lazy_ghost_objects' => true,
+                'enable_native_lazy_objects' => true,
                 'controller_resolver' => ['auto_mapping' => false],
             ],
         );
@@ -320,7 +319,6 @@ public function testCustomEntityManager(): void
                     'acb' => null,
                 ],
                 'controller_resolver' => ['auto_mapping' => false],
-                'enable_lazy_ghost_objects' => true,
             ],
         );
 
@@ -439,7 +437,6 @@ private function getContainer(array $config, array|null $dbalConfig = null, arra
 
         $container->getDefinition('doctrine.migrations.dependency_factory')->setPublic(true);
         $container->getDefinition('doctrine.migrations.configuration')->setPublic(true);
-        $container->addCompilerPass(new CacheCompatibilityPass());
 
         return $container;
     }
@@ -461,6 +458,7 @@ private function getContainerBuilder(): ContainerBuilder
             'kernel.environment' => 'test',
             'kernel.project_dir' => __DIR__ . '/../',
             'kernel.root_dir' => __DIR__ ,
+            'kernel.build_dir' => __DIR__ ,
         ]));
     }
 }